feat: add prefix option for authentication routes#1322
Conversation
|
This makes sense. However, could we rename |
done |
|
Please rebase your branch onto |
abd414d to
a1384fa
Compare
|
It looks like your branch was updated by merging/adding commits from
Those should not be part of this PR. Please rebase your branch on top of the latest If you do not already have the main Shield repository added as git remote add upstream https://github.com/codeigniter4/shield.git
git fetch upstreamThen rebase your branch: git checkout feat/prefix-options-to-routes
# optional safety backup
git branch backup/feat-prefix-options-to-routes
git rebase -i --rebase-merges --exec "git commit --amend --no-edit -S" upstream/developIn the interactive rebase, drop the unrelated commits listed above if they appear. Keep only the commits that belong to this PR. Then force-push the cleaned branch: git push --force-with-lease origin feat/prefix-options-to-routesPlease use rebase rather than merging |
a1384fa to
cc46a67
Compare
|
@dimtrovich Thanks for the PR! Previously, we encouraged users to handle this via standard route groups like so: $routes->group('accounts', static function($routes) {
service('auth')->routes($routes);
});However, this new Could you please add a quick reminder to the docs regarding filters? Something like:
|
Description
This pull request adds the ability to prefix all authentication route paths using a new
prefixoption in theroutes()method.prefixoption: Allows you to define a common prefix for all authentication routes (default/)‘/’with a configurable$prefixvariableBenefits of this change
auth/login,auth/register)namespaceandexceptoptions/preserves the existing behaviorUsage example
Checklist: